emilianoeheyns
About
- Username
- emilianoeheyns
- Joined
- Roles
- Member
Comments
-
Much appreciated BTW!
-
Correct, manually. Zotero will first migrate the keys out of extra, after that BBT will start. I'd be interested to know how long each takes and how many items are in your library.
-
does Zotero 8 log information about how long the migration phases took? It seems pretty speedy to me now, but numbers would be nice.
-
We've been holding the Z7 fields update until you resolve the performance issues. We don't want to push a release that results in a 40-minute upgrade. Though we could conceivably update the progress window to make clear that Zotero is done and it's …
-
For startup, you should be able to await Zotero.uiReadyPromise, at which point all items in the initially selected library will have been loaded. The two things I am thinking may need loadAllData is key gen and auto-export. If items from a never-se…
-
I have a test build at https://github.com/retorquere/zotero-better-bibtex/issues/3362, it would be nice to have confirmation, but it passes my test suites, so I intend to release after midnight. Every midnight the bulk test runs and I want to have i…
-
I would also prefer to stop calling loadAllData unnecessarily, and for that I need to be able to establish that an item or all items in a library have already been loaded.
-
Never mind. I'm going to just postpone BBT spinup until the lift has finished. Tests are running.
-
@erazlogo in Zotero 8, all keys will be pinned keys.
-
When is Z7 with citekeys coming out? I'm chasing ghosts where this entire bit of code is going to be scrapped in maybe days.
-
Ah I don't know what the final situation would be, I have so far interrupted the test before it could finish. I am seeing loads of stalled transactions. I'm not sure yet how I cause these yet, but if there is indeed the guarantee that after Zotero.…
-
I tested my database before start using this WITH x AS ( SELECT item.itemID, item.key as itemKey, item.libraryID, MAX(CASE WHEN f.fieldName = 'extra' AND idv.value LIKE '%citation key:%' THEN idv.value END) AS extra, MAX(CASE WHEN f.field…
-
Can you get me a database after all? I thought I had a database properly prepped with every item having an extra: line, but I am getting notifications for items that have neither an extra: line nor a citationKey field. If every item has an extra: li…
-
I think I have found the spot where I missed the lift.
-
Wait I do see the progress bar now. Once that goes and the popup in my screenshot shows, what phase is the extra lift in?
-
I have restarted the extra lift without BBT ever calling loadAllData
-
But that would mean there is no circumstance where I would ever have to call loadAllData, and I would not even have to try to detect whether items are loaded -- yet I was running into these problems. I don't know what the exact circumstances were, b…
-
Certainly not a stupid question. If there is a pinned key, BBT does nothing more than register that fact. I may be misdetecting the lifted key, which would cause key generation. I'm looking into that.
-
would be nice to have a progress bar for the extra migrations.
-
Batches of 100, but using a single notifier queue that's not triggered until the endSo that wouldn't trigger BBT during the migration, just after. I have a test that's running now. but are you calling item.loadAllData() every time you work with an i…
-
I'm not principally opposed to moving to zotero-dev, but is do a lot of my comms on mobile, and Google groups on mobile isn't great.
-
I'll set up a test with a migration on the 24k. How does the extra migration work? Batch or one by one?
-
I've just ran the 24k test with persistence disabled and as I expected, that is merely fractions of a second faster than with persistence. I could technically hand that off so it would not show up in the notifier timing, but it would consume this ti…
-
so this is absolutely due to BBTI think that's likely, but part of that is certainly key recalculation, and that won't be affected by the key persistence, whether batched or not. The batching is a good thing, cuts down the time a lot, but calculatin…
-
You'd see a delay there if a plugin takes a long time to do whatever it does when it receives those notifications.which I wouldn't expect the BBT key persistence to contribute (too) much to. The notifier responder registered the key in BBTs in-memor…
-
Probably not news, but these aren't BBTs, and I wouldn't typically expect the BBT "assigning" popup to appear in this scenario. That only happens when there are lots of keys without a BBT citekey. In this scenario, the items would typically have a B…
-
Setting debounce to 70 seconds runs in 60 seconds with a batch size of 24351 (all changes). I think 5 seconds will do.
-
A release build is running that batches key persistence so it only runs batched changes in one transaction at most once per 5 seconds. The 24k3 database runs key assignment in 66 seconds now, batch size average is 1842.
-
@emilianoeheyns: I explained on the dev list how to check whether this had completed, but that certainly shouldn't be necessary for auto-exports, which should just be debounced. Are they not?Good point -- they are. BBT shouldn't be running the same …
-
Right, that would have said "assigning keys". I've just tried in on a large database, for 24k items, all without keys; that took about 2 minutes. It will only trigger for as many items are hit by an extra-migration of course. But this does not modif…
Upgrade Storage