Edited ACS - error at the author listing

Hi
I edited the American Chemical Society style with the help of this forum and comparing/contrasting styles to get the style for Curr protein and peptide Sc. All seemed OK until at the reference listings I am suposed to have "[2] Last, F.; Last, F.M.; Last, F. Title. J. Org. Chem., 2005, 70, 10198-10201." with a semicolon after each author name. But I go something like: "Bensch, K.W. Raida, M. Mägert, H.J. Schulz-Knappe, P.; Forssmann, W.G. hBD-1: a novel beta-defensin from human plasma. FEBS Lett., 1995, 368, 331-335." As you can see it is not consistent.
Below is the edited Curr pr and peptide sc csl file. Your help is mch appreciated.

-----------
<?xml version="1.0" encoding="UTF-8"?>
<style xmlns="http://purl.org/net/xbiblio/csl" xml:lang="en" class="in-text" >
<info>
<title>Current Protein and Peptide Science</title>
<id>http://www.zotero.org/styles/american-chemical-society-with-titles</id>;
<link href="http://www.zotero.org/styles/american-chemical-society-with-titles"/>
<author>
<name>Julian Onions</name>
<email>julian.onions@gmail.com</email>
</author>
<contributor>
<name>Ivan Bushmarinov</name>
<email>ib@ineos.ac.ru</email>
</contributor>
<contributor>
<name>Sebastian Karcher</name>
<email>karcher@u.northwestern.edu</email>
</contributor>
<category term="numeric"/>
<category term="chemistry"/>
<updated>2010-07-26T02:21:30+00:00</updated>
<summary>The American Chemical Society style with article titles</summary>
<link href="http://pubs.acs.org/userimages/ContentEditor/1246030496632/chapter14.pdf" rel="documentation"/>
<rights>This work is licensed under a Creative Commons Attribution-Share Alike 3.0 License: http://creativecommons.org/licenses/by-sa/3.0/</rights>;
</info>
<macro name="editor">
<names variable="editor">
<name sort-separator=", " initialize-with=". " name-as-sort-order="all"
delimiter="; " delimiter-precedes-last="always"/>
<label form="short" prefix=", " text-case="capitalize-first" suffix="."/>
</names>
</macro>
<macro name="author">
<names variable="author">
<name sort-separator=", " initialize-with="." name-as-sort-order="all"
delimiter="; " delimiter-precedes-last="always"/>
<label form="short" prefix=", " suffix="." text-case="capitalize-first"/>
</names>
</macro>
<macro name="access">
<text variable="URL"/>
</macro>
<macro name="publisher">
<group delimiter=": ">
<text variable="publisher"/>
<text variable="publisher-place"/>
</group>
</macro>
<macro name="volume">
<group delimiter=" ">
<text term="volume" form="short" suffix="." text-case="capitalize-first"/>
<text variable="volume"/>
</group>
</macro>
<macro name="series">
<text variable="collection-title"/>
</macro>
<macro name="pages">
<label variable="page" form="short" suffix=". "/>
<text variable="page"/>
</macro>
<macro name="book-container">
<group delimiter=" ">
<text term="in" text-case="capitalize-first"/>
<text variable="container-title" font-style="italic"/>
</group>
</macro>
<macro name="issued">
<date variable="issued" delimiter=" ">
<date-part name="year"/>
</date>
</macro>
<macro name="full-issued">
<date variable="issued" delimiter=" ">
<date-part name="month" form="long" suffix=" "/>
<date-part name="day" suffix=", "/>
<date-part name="year"/>
</date>
</macro>
<macro name="edition">
<choose>
<if is-numeric="edition">
<group delimiter=" ">
<number variable="edition" form="ordinal"/>
<text term="edition" form="short" suffix="."/>
</group>
</if>
<else>
<text variable="edition" suffix="."/>
</else>
</choose>
</macro>
<citation>
<option name="collapse" value="citation-number"/>
<sort>
<key variable="citation-number"/>
</sort>
<layout prefix="[" suffix="]" delimiter=", ">
<text variable="citation-number"/>
</layout>
</citation>

<bibliography>
<option name="second-field-align" value="margin"/>
<option name="entry-spacing" value="0"/>
<layout suffix=".">
<text variable="citation-number" prefix="[" suffix="] "/>
<text macro="author" suffix=" "/>
<choose>
<if type="article-magazine">
<group delimiter=" ">
<text variable="container-title" font-style="italic" suffix="."/>
<text macro="edition"/>
<text macro="publisher"/>
<text macro="full-issued" suffix=","/>
<text macro="pages"/>
</group>
</if>
<else-if type="thesis">
<group delimiter=", ">
<group delimiter=". ">
<text variable="title"/>
<text variable="genre"/>
</group>
<text macro="publisher"/>
<text macro="issued"/>
<text macro="volume"/>
<text macro="pages"/>
</group>
</else-if>
<else-if type="book">
<group delimiter="; ">
<text variable="title" font-style="italic" />
<text macro="editor" prefix=" "/>
<text macro="series"/>
<text macro="edition"/>
<group delimiter=", ">
<text macro="publisher"/>
<text macro="issued"/>
</group>
<group delimiter=", ">
<text macro="volume"/>
<text macro="pages"/>
</group>
</group>
</else-if>
<else-if type="chapter">
<group delimiter="; ">
<text macro="book-container"/>
<text macro="editor"/>
<text macro="series"/>
<group delimiter=", ">
<text macro="publisher" />
<text macro="issued"/>
</group>
<group delimiter=", ">
<text macro="volume"/>
<text macro="pages"/>
</group>
</group>
</else-if>
<else-if type="article-journal">
<group delimiter=" ">
<text variable="title" suffix="."/>
<text variable="container-title" font-style="italic" form="short" suffix=","/>
<group delimiter=", ">
<text macro="issued" font-weight="bold"/>
<text variable="volume" font-style="italic"/>
<text variable="page" />
</group>
</group>
</else-if>
<else>
<group delimiter=" ">
<group delimiter=". ">
<text variable="title"/>
<text variable="container-title" font-style="italic" form="short" suffix=","/>
</group>
<group delimiter=", ">
<text macro="issued" font-weight="bold"/>
<text variable="volume" font-style="italic"/>
<text variable="page" />
</group>
</group>
</else>
</choose>
</layout>
</bibliography>
</style>

------
  • edited June 20, 2011
    It looks like you've found a bug.

    @fbennett: the style validates, and I also see the problem with the updated CSL 1.0 version: https://gist.github.com/1036121

    The "; " delimiter is used correctly when I remove name-as-sort-order="all" from the author macro. Also, using delimiter=";; " gives

    Otero, J.M.; Vongsangnak, W.; Clark, A.;; Nielsen, J.
  • Without having done any changes to the ACS Style I had the same problem as rtoubar above.

    Following the comments of Rintze I got rid of the problem by making a modified ACS style file.

    Now, I know absolutely nothing about CSL, but maybe someone here could enlighten me:
    Is the long term solution simply the modification as lined out above? Or should it be something else? Should I upload my modified ACS style anywhere?
  • this has since been fixed in the csl processor and the original style will work correctly in the next version of Zotero, so no need to upload your modified style.
  • I didn't notice it yesterday, but it seems there's another problem with my 'fix' - now names are no longer 'Last, I.' (as they should be) but rather 'I. Last' (which is wrong).
    Is there an easy way to fix this?
    Or will I have to wait for the next version of Zotero? (if so, any indications of when such is coming?)
  • right, that's why your fix isn't really a fix - that's what the line you deleted does.
    Usually small releases in Zotero happen every month or two, but I don't know about an ETA. If you're in a hurry you can install the branch xpi, which tends to be very stable at this point:
    http://www.zotero.org/support/dev/svn_and_trac_access#zotero_client_dev_xpis
  • Thanks, I'll see what the status is by the time I'm ready to finalise the document I'm working on.
  • Hi AdamSmith

    I was wondering if there is a way to know whether Zotero has been updated; I've refreshed my documents and I am still having the problem explained above. Because I know noting about CSL and created that file by modifications, trials and errors, I would appreciate t if you can have a quick look at it and confirm if I am supposed to get the references list like this example: "[2] Last, F.; Last, F.M.; Last, F. Title. J. Org. Chem., 2005, 70, 10198-10201."

    Much appreciated
    Rabab
  • no it hasn't - if you need the newest version use the branch xpi, I'm not sure if Zotero even plans to release a 2.1.9, as the 3.0 is just before a beta release.
  • I think 2.1.9 should be coming regardless. There's been a fair amount of work done on the 2.1 branch, including big, useful things like translator testing, and loads of smaller bugfixes.
  • Yes, 2.1.9 is definitely coming.
Sign In or Register to comment.