Minor issue related to colored tags

qqbb
When multiple items are selected, of which only a subset has tag "1", pressing "1" gives different results depending on the position of the item that already has the tag. Here are two examples for illustration:

Example 1:
item1, tag: "1"
item2, tag:
-> selecting both items and pressing "1" results in:
item1,tag:
item2,tag:

Example 2:
item1, tag:
item2, tag: "1"
-> selecting both items and pressing "1" results in:
item1, tag: "1"
item2, tag: "1"

The expected behavior in both cases would be as in example 2.
  • dstillman
    edited November 5, 2019
    The current behavior is by design. We use the state from the top-most item, with the idea that there's a good chance that was the first item you were looking at and that you want to toggle the tag on that item.

    But what you propose may be clearer and more predictable. So it would be that if any selected items didn't have the tag, we would apply it to all items first. If all selected items had the tag, we'd clear it.
  • adamsmith
    Yeah, the proposed alternate behavior definitely seems clearer and less confusion-prone to me.
  • pjweiss
    I agree that the proposed behavior would be better than the current behavior.
  • dstillman
    I've made this change in the latest beta.
  • qqbb
    Thanks! This works as expected now.
  • dstillman
    This change is now available in Zotero 5.0.96.3.
Sign In or Register to comment.