PDF icon on link attachments (possible bug?)
@dstillman
Some link attachments (those that end in .pdf) have a red PDF icon. However, other link attachments just blue link icon. That doesn't seem to be like this on non-beta versions (or I could be wrong). In any case, it's a recent change.
It's a bit confusing, because even links that don't end in .pdf may directly resolve to a pdf.
If it's intended, would it be possible to have a separate icon for this, such as a PDF icon with the link symbol ontop? Or the old blue link-type icon with PDF written on it?
(5.0.61-beta.25+ce1fc6635, but it's been like that for one or two beta updates at least.)
Some link attachments (those that end in .pdf) have a red PDF icon. However, other link attachments just blue link icon. That doesn't seem to be like this on non-beta versions (or I could be wrong). In any case, it's a recent change.
It's a bit confusing, because even links that don't end in .pdf may directly resolve to a pdf.
If it's intended, would it be possible to have a separate icon for this, such as a PDF icon with the link symbol ontop? Or the old blue link-type icon with PDF written on it?
(5.0.61-beta.25+ce1fc6635, but it's been like that for one or two beta updates at least.)
If the item is a link to a URL on the internet, it will have the web link icon.
@dstillman - So at the moment locally stored PDFs (under Zotero control) have the same icon as PDF-links? At least that's what I see.
Is that intended or not?
If yes - I do think that's confusing - let me argue this :)
- I now need to look at the blue dot as well as the icon to work out where the file is.
- When I double click the icon (without looking at the blue dot) either the browser will open (for the link) or my PDF reader. That's inconsistent.
- Further, links that resolve to PDFs but don't end in .pdf are still shown with the attachment icon.
- Also, despite the icon showing as PDF, the PDF may or may not be retrieved with 'find available PDF'.
So ... my vote would be that the icon to "PDF under Zotero control" and the icon for "link ending in .pdf" should be different, e.g. by adding the link icon to the latter?
Or am I misunderstanding? :)
These are the icons you should see (and which I see):
Stored-file PDF: https://github.com/zotero/zotero/blob/master/chrome/skin/default/zotero/treeitem-attachment-pdf@2x.png
Linked-file PDF: https://github.com/zotero/zotero/blob/master/chrome/skin/default/zotero/treeitem-attachment-pdf-link@2x.png
That's a bug. That should probably continue to show the blue-page-with-link icon.
Yeah, that's it - sorry for the confusion. I don't have any local files outside Zotero!
> That's a bug. That should probably continue to show the blue-page-with-link icon.
Yes that makes sense!