Style validation change?

SamSaville
Hi,

I created my own citation stye a few years back which has been working fine. However today firefox has decided it isn't valid - has something changed?

What is going to be the easiest way to fix it?

I remember it took me a longggggg time to work out the coding to get that far - I'm not in any way experienced with CSL, so go gently with me!

Thanks!
«13
  • LiborA
    edited April 14, 2016
    try http://validator.citationstyles.org/ or send your code on https://gist.github.com/ and put the link here.
  • adamsmith
    edited April 14, 2016
    (but to answer your question -- the the last time a change was made that would make an valid style invalid was in 2011, so no).
  • abeyhom
    I had the same problem this morning, and have changed the style and validated it at http://validator.citationstyles.org/. Then I recopied the emendated style in the styles folder of zotero, and started firefox and word: whenever I ask for my style in the zotero document preferences in word, I still have the same problem.

    Any ideas?
  • adamsmith
    we'd want to see the style -- post to gist.github.com and provide the link here.
  • abeyhom
    https://gist.github.com/anonymous/0d2ef60feee384974b34dea15a15f0e6
    I have saved both original (from 2012) style and the emended and validated version (which still does'nt work).

    Thanks
  • step4
    edited April 14, 2016
    I have a similar problem, using a style, which on http://validator.citationstyles.org/ is said to contain no errors.
    Using the Firefox-Plugin, it is not accepted, since yesterday.

    BUT when I install the Standalone-Version and use the Chrome-Connector all works fine.

    I guess, that the trouble has to do with the Firefox Update 45.0.2.
    The question is, if the error occurs because of an error on the side of Firefox - or if they are the first to implement some new "rules", which would mean, that with a future Chrome-Update, we will have the same problem also there?

    Does anybody have any ideas or information on this?
  • abeyhom
    Additional info: I had to reinstall both Firefox and zotero (last versions) yesterday, after a crash of Firefox
  • step4
    The style of abeyhom (emended, val. vers.) does not work though for me, whether via Firefox-Plugin nor via Chrome-Connector (Standalone).
  • adamsmith
    This might not be the best error message, but it actually is a real problem with the style:

    <macro name="contributors">
    <names variable="author">
    <name and="text" name-as-sort-order="first" sort-separator=", " delimiter=", " delimiter-precedes-last="never">
    <name-part name="family" font-variant="small-caps"/>
    <name-part name="given" />
    </name>
    <label form="verb-short" prefix=", " suffix="." text-case="lowercase" strip-periods="true"/>
    <substitute>
    <text macro="editor"/>
    <text macro="translator"/>
    </substitute>
    </names>
    <text macro="anon"/>
    <text macro="recipient" prefix=" @ "/>;
    <text macro="contributors"/>
    </macro>

    The second but last line here causes an infinite loop. Zotero is right to refuse to select that style. Remove that line and I think this should work. I'm not sure where in the code this was implemented, to be honest, but it's good to see it.
  • abeyhom
    I see the problem: I removed the line, but it doesn't work though.

    Thanks anyhow!
  • step4
    "Remove that line and I think this should work."

    Just tried it out. It works on Standalone using Chrome-Connector, still not working using Firefox-Plugin.
  • adamsmith
    I see. I'm curious -- there are three people here but I'm only seeing one custom style. Is everyone having the problem with the same style or are there different custom styles that have also stopped working?
  • Sammour
    I also had the problem today. A friend of me too. I am using a custom styles i made years ago.
  • adamsmith
    We'd want to see as many samples as possible (post to gist.github.com as above). I just tested with one of my custom styles and that works fine, so it's not that all custom styles are broken.
  • tsolga
    Since today I have got the same problem as SamSaville and the others with my custom style using the Firefox plugin. I checked the style with validator.citationstyles.org, simonster.github.io/csl-validator.js and validator.nu - no errors found. Here it is:
    https://gist.github.com/anonymous/773010662584a52a7d792caefdd00323

    I also downgraded Firefox to 45.0 - no success either.
  • Sammour
    I find many styles who doesn't work, like :
    The one i customize (ERSAM-Histoire et sources anciennes) : https://gist.github.com/anonymous/5677263cff4c1f5d404f79b082137504
    Tapuscrit : https://www.zotero.org/styles/le-tapuscrit-note?source=1
    Another custom style (base on Elsevier - Harvard) : https://gist.github.com/anonymous/f357c8553cc9fa0477283cfc115545ae
  • adamsmith
    Tapuscript from the Zotero repository works for me. Are you sure that throws the same error?
  • Sammour
    No i am not, is there some log to have a look on the error ?
    in both case i have this message in french : "Une erreur s'est produite lors de la création de votre bibliographie. Veuillez réessayer."
    It's mean, error happened when creating your bibliography, you should try again...
  • adamsmith
    no, for the purpose of this thread I'm only interested in the specific error described in the first and several other posts: On selecting or using the style in question, you get a Zotero error message in your word processor that the style isn't valid.

    If there are other problems, we'd want to handle those separately.
  • Sammour
    Okay, i think i start a confusion... i am sorry
    in fact, some csl style can't be add (zotero said he is not valid) and use (it say that an error happened).
    Other csl style can be add but not use (it say that an error happened). So don't talk about these you are right.

    The style "ERSAM-Histoire et sources anciennes" can't be add because he is not valid : https://gist.github.com/anonymous/5677263cff4c1f5d404f79b082137504 (and can't be use anymore)
    The style "ERSAM-Histoire et sources anciennes-sansColl" who is a minor fork of the one before, can be add, but can't be use also : https://gist.github.com/anonymous/c5575be03687e9808178ac9bd2949c40
  • tsolga
    @adamsmith:
    The translation of the German error message I get in LibreOffice is:
    "The chosen style seems not to be valid. If you have created the style yourself please make sure that it passes the valdidation at http://zotero.org/support/dev/citation_styles. Otherwise please select another style."
  • adamsmith
    yes, I can replicate your error. That's the one I'm interested in here. I'll see what I can figure out tonight. I now have a reasonable amount of data to work with.
  • LiborA
    edited April 14, 2016
    @Sammour: in your ERSAM custom styles are a lof of errors:

    1. in first style missing xmlns on line 2: <style xmlns="http://purl.org/net/xbiblio/csl" class="note" default-locale="fr-FR" version="1.0" page-range-format="expanded">

    2. Attribute “demote-non-dropping-particle” not allowed on element “name” (line 48, 60, 71, 79, 88, 97, 106)

    3. Element “text” not allowed as child of element “date” (line 205, 294) - copy code in line 205 behind 206 and code in line 294 behind line 295 respectively lines 185 and 274 in second style.
  • RintzeRintze
    edited April 14, 2016
    Yeah, adding the <style xmlns="http://purl.org/net/xbiblio/csl" ...> fixes the error

    Error parsing style:
    TypeError: Zotero.Utilities.xpathText(...) is null

    in the "ERSAM-Histoire et sources anciennes" style. (although the other errors highlighted by LiborA should be fixed as well)
  • LiborA
    @tsolga: I do not have problem with your style if I use standalone Zotero, but if I use Firefox extension this style is not working :(

    Q: Why this style sort bibliography twice by the author?
  • tsolga
    edited April 14, 2016
    @LiborA:
    It was sorted by type of contribution and author before. Then I delete the first criterion. Thus the doubling is some kind of relict. :) Thanks for the hint!
  • adamsmith
    @tsolga -- could you try this version:
    https://gist.github.com/adam3smith/0681ae2b8bd3faf3cceffbb8ee9674f1
    only change is the presence of a rel="self" link.
  • adamsmith
    @abeyhom -- try https://gist.github.com/adam3smith/481245b731d50cc35cbae7d484524b68

    The only change is to use http:// for id and self link

    @all -- so yeah, make sure id and self link are both present and in a valid format ("valid" only in terms of syntax; there still doesn't need to be a file at that URL).
  • abeyhom
    @adamsmith -- I have tried : I checked the style with http://validator.citationstyles.org/, with no errors, but I stll have the same problem when trying to choose this style in Document preferences (word)...
  • Sammour
    Okay you were write and i can add the style again (i juste made a wrong correction...)
    But i style have the same problem as abeyhorn with my style (i made all correction to pass the CSL Validator as you can see) :
    https://gist.github.com/anonymous/2a8aa9afeeb72d23c618309fa8c65a51
Sign In or Register to comment.