Citation style: Edition disappears

aberehrlich

I changed a citation style to adapt it to my needs. It all worked well. Today, I wanted to use it again and I realized that the edition somehow disappeared in notes and bibliography. Have I changed something or did the updates of Zotero / CSL changed it? Also, URLs are missing now. Here is my code, I looked now for hours on it but could not find the problem. Maybe it is a problem in "issued"? Thank you for your help.

https://github.com/aberehrlich/zotero/blob/92a1fc11b11dc628aa95cca9d3eade846ebb8d1d/schmitt_zeitgeschichte

damnation

I assume you mean editions for books and chapters.
In the "if" starting in line 755 you're not calling the "issued" macro that contains your "edition" macro.

URLs are missing for which item type? (Please always include the item type when asking such questions)

adamsmith

You're not calling the macro "issued" for books or book chapters (you test for them in line 755 and then have an else condition starting in line 774).

For the bibliography, edition should appear for books (line 829) but wouldn't for any other item types -- neither macro nor edition appear anywhere.

The style also isn't valid CSL, I believe. Make sure to validate and fix any issues: https://validator.citationstyles.org/

damnation

Generally, I'd also try to mirror your conditionals for the item types.

For in-text citations you have: if book & chapter, else-if interview, else.
In the bibliography you have: if book, else-if article, else.

aberehrlich

@damnation: Yes, books and chapters. Thank you so much for your help and time. I now understand it better and got a work around. In line 755, I do not call the "issued" macro. I (or the code I adapted) thought I was calling it in the macro "date-in-text". But I now realized that this was only partially true, as only certain variable were called there.

Concerning the item type: I talk about the "document" item type. In the older Zotero versions it was the most suitable thing for websites, archive documents and much more, so I used it a lot. Is it possible that something changed here, as the code I used was referring to it as "article", as no "document" is supported?

damnation

For webpages I'd use the item type "webpage".

This will be helpful for you: https://aurimasv.github.io/z2csl/typeMap.xml

It maps out the various fields you see in Zotero vs the variables in CSL.