`Zotero.Item.attachmentFilename` should only return filename?

Haizs · November 13, 2020

Code here: https://github.com/zotero/zotero/blob/d5ac87648b235c53463caa3fe847c67cc730ad11/chrome/content/zotero/xpcom/data/item.js#L2842

If use Linked Attachment Base Directory, the return of `.attachmentFilename` includes relative path instead of only filename, a bug maybe?

Related discussion:
https://forums.zotero.org/discussion/comment/362214
https://forums.zotero.org/discussion/69071/zotfile-always-send-to-created-subfolder-on-tablet-from-zotero-collections

dstillman · November 13, 2020

I don't know what this is supposed to be. Is this a development question? If so, you should post to zotero-dev and explain that.

dstillman · November 13, 2020

@Haizs: But yes, this is arguably a bug. Here's what the function's comment says:

This will return the filename for all file attachments, but the filename can only be set for stored file attachments. Linked file attachments should be set using .attachmentPath.

It's a little weird that this works at all for linked-file attachments, but if it's going to, it should probably strip the relative path. I'll fix this. Thanks.

(No need to post this to zotero-dev.)

dstillman · November 13, 2020

This is fixed in the latest Zotero beta.