Upgrade Storage"DEPATISnet" translator largely broken
Hello everybody,
first of all I would like to thank all those who have so generously developed this great program and continue to maintain it: Thank you very much!
Since a couple of weeks I have noticed that the translator of the FireFox plugin for depatisnet (the german patent office site; https://depatisnet.dpma.de/DepatisNet/depatisnet?window=1&space=menu&content=index&action=index), DEPATISnet.js, does not work properly in most parts:
If you try to take over the patent in Zotero on the bibliographic data page (e.g. https://depatisnet.dpma.de/DepatisNet/depatisnet?action=bibdat&docid=FR000001547439A), the only thing that is recognized is that it is a patent. The entry that is then created in Zotero will only contain the patent number in the metadata. The number is also used as the title. The link to the website is also added. The patent pdf will not be downloaded.
In the past, all bibliographic data was correctly transferred (title, inventor, publication date, ...) and the corresponding pdf was automatically downloaded. All this does not work anymore.
I took a closer look at the Javascript of the Translator.I have determined that the if block statement from line 203 on (i.e. downloading the pdf) is not executed, because the content of the variable 'pages' does not seem to be correct (always 0 I think). Commenting out the if condition has caused the pdfs to be downloaded automatically again.
If you try to transfer a patent to Zotero for which no pdf is stored (e.g. https://depatisnet.dpma.de/DepatisNet/depatisnet?action=bibdat&docid=FR000000346003A), the small infobox that always appears when you click on the icon of the plugin will show a hint that downloading the pdfs did not work. If I have understood the source code correctly, the if statement should prevent just that.
However, the bibliographic data is still not transferred to Zotero and all other problems as described above still exist. I suspect that the information from the web page is no longer read correctly in the translator (I also have the impression that the Patent Office web page has changed slightly).
By the way: If you try to add a file in Zotero after a patent entry from depatisnet with missing pdf by "right-clicking on the entry --> find available pdf", this function will not be completed. The progress bar does not even start to run. The function can only be terminated by clicking the "Cancel" button.
Unfortunately, my programming skills are not sufficient to find out the error more precisely or even to fix it. Therefore I ask better qualified people to take care of the problem. I will gladly support you as far as I can.
Thanks and many greetings
Simon
first of all I would like to thank all those who have so generously developed this great program and continue to maintain it: Thank you very much!
Since a couple of weeks I have noticed that the translator of the FireFox plugin for depatisnet (the german patent office site; https://depatisnet.dpma.de/DepatisNet/depatisnet?window=1&space=menu&content=index&action=index), DEPATISnet.js, does not work properly in most parts:
If you try to take over the patent in Zotero on the bibliographic data page (e.g. https://depatisnet.dpma.de/DepatisNet/depatisnet?action=bibdat&docid=FR000001547439A), the only thing that is recognized is that it is a patent. The entry that is then created in Zotero will only contain the patent number in the metadata. The number is also used as the title. The link to the website is also added. The patent pdf will not be downloaded.
In the past, all bibliographic data was correctly transferred (title, inventor, publication date, ...) and the corresponding pdf was automatically downloaded. All this does not work anymore.
I took a closer look at the Javascript of the Translator.I have determined that the if block statement from line 203 on (i.e. downloading the pdf) is not executed, because the content of the variable 'pages' does not seem to be correct (always 0 I think). Commenting out the if condition has caused the pdfs to be downloaded automatically again.
If you try to transfer a patent to Zotero for which no pdf is stored (e.g. https://depatisnet.dpma.de/DepatisNet/depatisnet?action=bibdat&docid=FR000000346003A), the small infobox that always appears when you click on the icon of the plugin will show a hint that downloading the pdfs did not work. If I have understood the source code correctly, the if statement should prevent just that.
However, the bibliographic data is still not transferred to Zotero and all other problems as described above still exist. I suspect that the information from the web page is no longer read correctly in the translator (I also have the impression that the Patent Office web page has changed slightly).
By the way: If you try to add a file in Zotero after a patent entry from depatisnet with missing pdf by "right-clicking on the entry --> find available pdf", this function will not be completed. The progress bar does not even start to run. The function can only be terminated by clicking the "Cancel" button.
Unfortunately, my programming skills are not sufficient to find out the error more precisely or even to fix it. Therefore I ask better qualified people to take care of the problem. I will gladly support you as far as I can.
Thanks and many greetings
Simon
(posting problems here first, as you did, is much preferred, so thanks for that)
thank you for your hint to post my problem on github. This is what I did then (https://github.com/zotero/translators/issues/2197). In the meantime I was able to solve the problem myself and adapted the source code for the translator in question (https://github.com/zotero/translators/pull/2211). The changes have passed the test.
As I understand it, this would clear the way for the changes to be included in the official version, right? Unfortunately I don't know how this works or who I have to contact for this.
Can you or someone else explain to me how to proceed so that everyone else can benefit from my error correction? Unfortunately, this is the first time I am doing something like this. Therefore I am sorry that I do not know myself how to proceed.
Many thanks and best regards
Simon
At some point this would be really helpful to properly capture and manage patents as references. Manually entering the infos in Zotero is not very efficient, so thanks in advance.