OpenLibrary.org

valerietheblonde

Hello! Longtime user, first time poster. The openlibrary.org parser is broken. I ran the book through scaffold:
14:44:24 Detect using The Open Library failed:
string => TypeError: Function.prototype.apply called on incompatible undefined
stack => Zotero.Translate.Base.prototype._detectTranslatorLoaded@chrome://zotero/content/xpcom/translation/translate.js:1512:22
Zotero.Translate.Base.prototype._detect/<@chrome://zotero/content/xpcom/translation/translate.js:1500:17
Zotero.Translate.Import.prototype._loadTranslatorPrepareIO/initCallback@chrome://zotero/content/xpcom/translation/translate.js:2045:17
Zotero.Translate.IO.String.prototype.init@chrome://zotero/content/xpcom/translation/translate.js:2541:4
Zotero.Translate.Import.prototype._loadTranslatorPrepareIO@chrome://zotero/content/xpcom/translation/translate.js:2072:3
Zotero.Translate.Import.prototype._loadTranslator/<@chrome://zotero/content/xpcom/translation/translate.js:2028:3
Zotero.Translate.Base.prototype._loadTranslator@chrome://zotero/content/xpcom/translation/translate.js:1570:16
Zotero.Translate.Import.prototype._loadTranslator@chrome://zotero/content/xpcom/translation/translate.js:2027:2
Zotero.Translate.Base.prototype._detect@chrome://zotero/content/xpcom/translation/translate.js:1499:1
_run@chrome://scaffold/content/scaffold.js:435:4
run@chrome://scaffold/content/scaffold.js:369:4
oncommand@chrome://scaffold/content/scaffold.xul:1:1

url => undefined
downloadAssociatedFiles => true
automaticSnapshots => true
14:44:24 detectImport did not match

Then I tested all of the TranslatorTesters:
14:34:18 TranslatorTester: Running 1 test for The Open Library
14:34:18 TranslatorTester: Running The Open Library Test 1
14:34:20 TranslatorTester: Translating http://openlibrary.org/books/OL13188011M/Borges
14:34:21 Translation using The Open Library failed:
thrown exception => DOMParser error: loading data into data store failed
url => https://openlibrary.org/books/OL13188011M/Borges
downloadAssociatedFiles => true
automaticSnapshots => true
14:34:21 TranslatorTester: The Open Library Test 1: failed (Translation failed: DOMParser error: loading data into data store failed)

Cheers,

Val

adamsmith

It's their bug:
https://openlibrary.org/books/OL13188011M.rdf
they use an undefined prefix in their RDF data. I've written them about this, will wait a couple of days if they respond, otherwise work around it.
Thanks for reporting.

valerietheblonde

I wasn't aware of that bug. Thanks for working on this.

adamsmith

OK, OL says they don't have the capacity for much maintenance anymore & to not expect a quick fix, so I've put a workaround into the Zotero translator (adding the namespace declaration to the RDF, should you care about the details) and this works again.

Ezt

Hello !
I've the same problem but I didn't really understand how to fix it. Can you give some details ?

Cheers,

Sebastien.

adamsmith

their fix and our workaround didn't play nice with each other. It's now working again (after you update your translators using Update Now in the preferences).

valerietheblonde

Thanks again for working on this, Adam. One day soon I'll be able to contribute.