style for Plant Pathology

phyto

Hi all,

I made a style for the journal Plant Pathology, by modifying the style of Molecular Ecology with the visual editor.
The code is here : https://gist.github.com/anonymous/6377732
It validated at http://simonster.github.io/csl-validator.js/ and I could use it in Word.

adamsmith

thanks! Could you add yourself as an author for the style, add ISSNs, add a working link to the instructions for authors and specify molecular ecology as the template?
(see in particular 6, 8, and 9 here: https://github.com/citation-style-language/styles/wiki/Style-Requirements )

If you'd consider following the method described under A here
https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md
that'd make things a lot easier for us, though we'll accept the style either way.

phyto

OK, I will add what is missing and try to submit the code as you suggest (option A - pull request). I did not submit the code this way at first attempt because I am not familiar at all with GitHub.

There is also a disambiguation issue that needs to be fixed (for the moment in-text citations are (X, Y, et al. 2013) and (X, Z, et al. 2013) whereas it should be (X et al. 2013a) and (X et al. 2013b) - I will try to fix it myself with the visual editor and post here if I cannot succeed.

phyto

I fixed the disambiguation issue and pulled a request with the updated code.

However since then I made another modification to the style (for in-text citations without authors, citations appeared with an extra space like "( 2013)" instead of "(2013)". I guess I have to wait for the pull request to be accepted before I can upload any modification, is that correct?

Rintze

I guess I have to wait for the pull request to be accepted before I can upload any modification, is that correct?

No. For the full answer, see https://github.com/citation-style-language/styles/pull/680#issuecomment-23562190

adamsmith

(and thanks for going through with the pull request - we really do appreciate that).

phyto

I updated the pull request, I hope I did it correctly.

adamsmith

you did, but you lost/reverted some of your other fixes on the way - see my comments on github.

phyto

you are right, I made a confusion and edited a wrong version of the style when I made the last modification. Sorry about that.

I updated the pull request on github and everything should be OK now.

phyto

A minor issue about the current version of this style (latest pull request update): it seems that there is a discrepancy between the display of the visual editor and what happens in Word.
For instance, with 3 different references of Smits et al. 2010:

In the visual editor, I get:
(Smits et al., 2010a, b, c)

In Word:
(Smits et al., 2010a; b; c)

I wondered if this is anyhow a mistake of my part, or a minor bug of either the Word plugin or the visual editor?

I have found one example of such a case in Plant Pathology and it was as such : (Bruno & Sparapano, 2006a,b; Bruno et al., 2007)

I have looked there: http://citationstyles.org/downloads/upgrade-notes.html#citation-collapsing and I have tried inserting year-suffix-delimiter="," in <citation> line 72 and then I get the expected output in Word: (Smits et al., 2010a,b,c)

Should I wait that you have a quick look at this (difference between visual editor and word plugin) before updating this style on github with year-suffix-delimiter=","?

adamsmith

this is a bug in the visual editor, probably an old processor version or so? As the specs say: "Both attributes default to the delimiter set on the cs:layout element within cs:citation."
i.e. the semicolon is the correct output given the current version of the style, so please yes, do update the pull request with year-suffix-delimiter=",".

The rest looks great.

phyto

pull request updated.

adamsmith

merged. The style is now up. It will show up on the repository within 30mins. It may take up to 24hs for the preview to work.
If you submit corrections or additions to the style in the future, please always work with the most recent copy from the style repository, as we frequently adjust the formatting of styles slightly.

Thank you for contributing!

Norman_D

Hi all,

I'm a new user of Zotero, using it before I submit a paper to Plant Pathology.

Thank you very much Phyto for creating this style. If you read this, would it please be possible for you to update the style so that it gives the DOI of the cited article in the reference list ?

Maybe if you don't someone else could do it (please) ?

I do not know how to do it myself.

Thank you in advance.

adamsmith

Do you have a link to the guidelines that say the DOI should be added?

Norman_D

https://www.springer.com/journal/42161/submission-guidelines, this is the link of the web page.

and this is an extract from the page :
[ If available, please always include DOIs as full DOI links in your reference list (e.g. “https://doi.org/abc”).

Journal article
Gamelin FX, Baquet G, Berthoin S, Thevenet D, Nourry C, Nottin S, Bosquet L (2009) Effect of high intensity intermittent training on heart rate variability in prepubescent children. Eur J Appl Physiol 105:731-738. https://doi.org/10.1007/s00421-008-0955-8 ]

Thank you for answering, I thought my comment would take longer to get moderated and then anwered.

damnation

I completely reworked the style as it was not at all in line with the guidelines anymore.
Try this (open Zotero, click on link): removed.
(See comment below)

Norman_D

I copy/pasted the script from your link (thank you for that) but I am unable to use the style.
I opened "preferences" and then the style editor, but I can't get Zotero to allow me to go and select the style from the location where i saved it on my computer.
Would you please have further advice for me ?

damnation

As I said above, open Zotero and CLICK on that link.
If that doesn't work, RIGHT CLICK on that above link, save as..., Double click the file and Zotero will pick it up.

Norman_D

Thanks, I read the "Alternative Installation Methods" from one of the Zotero documentation pages, and it worked.

Yes I had cliked on the link but it only opened a new wep page containing your updated version of the code. I didn't right click right away as a reflex.

Thank you very much for this !

damnation

Two similar-sounding journals were mixed up here:

Springer's "Journal of Plant Pathology" (eISSN: 2239-7264; Print ISSN: 1125-4653)
)style: https://www.zotero.org/styles?q=id:springer-basic-author-date-no-et-al

Wiley's "Plant Pathology" (eISSN: 1365-3059) style: http://www.zotero.org/styles/plant-pathology

Norman_D

Thank you for nociting and reporting my mistake.