style for Geological Magazine created

daoane

I uploaded a style for Geological Magazine of Cambridge University Press. Please add it to the repository.

https://gist.github.com/995081

adamsmith

Thanks - the repository is now csl 1.0 only:
http://citationstyles.org/downloads/upgrade-notes.html#updating-csl-0-8-styles
Please convert your style, remove the (dev) at the end of the title, and also add a suitable field for the style - it wouldn't appear to be a "generic-base" style.

daoane

Done: https://gist.github.com/995828

"generic-base" was already set in the 0.8 version, so I didn't touch this.

Rintze

"generic-base" is used for styles that aren't specific to any particular field of study. For this style, you can use "geology" (see http://citationstyles.org/downloads/specification.html#categories ).

Also, you use an XML processing instruction, which is rather awkward:
<?This style is based on the harvard1 style by Julian Onions, http://www.zotero.org/styles/harvard1?>

If you want to keep this information, you can either add it to the content of the cs:summary element, or use a cs:link element with the "rel" attribute set to "template", and the "href" attribute set to the URI of the harvard1 style (see http://citationstyles.org/downloads/specification.html#info ). It's also not necessary to list Julian Onions as a contributor in your style.

Rintze

Also, you use cs:link twice with "rel" set to "self". For the second use, "rel" should be set to "documentation" (and the URL should probably be http://journals.cambridge.org/action/displayMoreInfo?jid=GEO&type=ifc instead of http://journals.cambridge.org/action/displayJournal?jid=GEO ).

daoane

Not so easy to get everything right with the first style. I hope it's alright now.
I also removed the contributor though I read (can't find the page right now) that one should list the author of the style which one modifies as a contributor.

https://gist.github.com/996941

adamsmith

Don't take this as criticism - it's just so much easier for us to upload when everything is in order and we can just push the style to the repo - your style looks great otherwise. It's up now and will show up in the Zotero repo within a couple of hours.
I believe you're right and the directions suggest leaving the original author as contributor - it's not a hard and fast rule. I tend to follow it, Rintze apparently disagrees (and he's usually right on those issues), doesn't matter greatly either way.

daoane

Thanks! No, I don't take it as a criticism "the bad way" - it's just somehow embarrassing to bother you with mistakes after one (mis)reads the instructions and misses some important point every time

Rintze

You're not bothering us. We appreciate every style contribution (so thanks! :) ), and we always try to make the instructions clearer.

As for listing the author of the original style as a contributor in the derived style, I think that that is superfluous once you list the original style as the template (so I would support changing the directions). But it's a (unimportant) matter of preference.

A small issue: I should have mentioned it, but the ampersand in the URL I suggested should be escaped ("& amp;" [without the space] instead of "&"). I fixed this. I also added a hyphen in the style name to separate the two words in the journal title.

https://github.com/citation-style-language/styles/commit/bdbf2155d73e8fda55d796871f618feb71afab20

The updated style is now up in the style repository.

adamsmith

I adjusted the instructions for submitting to reflect this.