ACM Translator Error/Bug

wbt

I am having a "Could Not Save Item" error at http://portal.acm.org/citation.cfm?id=558412 when clicking on the translator button in the address bar.
Error report ID #: 347779095

The issue may be about item type. The translator button resembles e. g. Journal Article, but the item is of type Book.

Any ideas on how broad the issue is, or how to fix it?
WBT

ajlyon

Please go to http://github.com/ajlyon/zotero-bits/raw/master/ACM.js and save the file to the translators directory of your Zotero data directory (http://www.zotero.org/support/zotero_data).

It should start working again. If this works for you, please post here so that I can submit this change to be pushed to all users.

kynan

I see the "Could not save item" issue with this item from the ACM Digital Library (a doctoral dissertation): http://portal.acm.org/citation.cfm?id=1023242

Error report ID #: 519178136

The error console gives:
Error: TypeError: newItem.url is undefined
Source File: file:///home/***/.mozilla/firefox/Profile/zotero/translators/ACM%20Digital%20Library.js
Line: 0

wbt

With ajlyon's modified ACM.js, I still observe the same "Could not save item" issue with both of these sample item links.
I've removed that experimental translator from my "translators" directory; there wasn't one there before (though there is an "ACM Digital Library.js").

adamsmith

try replacing the ACM Digital Library.js with ACM.js - you can just move the old one outside the translator directory - restart FF and see if that helps.

ajlyon

Yes-- try adamsmith's approach. The version on Github should work for all the examples above already.

wbt

Yes, the new file works for both of these examples.
It still fails to get the location right, for example the first link should have a Place of "Sebastopol, CA" since that's where the book was published - but that is more pertinent to the discussion at http://forums.zotero.org/discussion/18296/acm-translator-bug/ than here. Ajlyon's fix overcomes the "Could not save item" error that this thread is about.
Thank you, Ajlyon!

-WBT

ajlyon

This is now in the zotero.org repository and should be in the next version of Zotero.