Upgrade StorageStroke Eraser implementation
Hi,
I've finished the stroke eraser implementation I started a year ago in https://forums.zotero.org/discussion/110079/ios-object-stroke-eraser#latest. The UX is basically the same as the eraser in Notability and on the Remarkable. It supports undo, and I've also added a setting that allows the user to configure how the stroke tool should merge strokes (separate strokes means higher file sizes but better stroke erasing).
I did use Claude to help with much of the implementation (undo functionality; stroke merging settings) but I have also reviewed all of the code manually.
I am happy to make any changes to get this merged. I would like to get it merged soon; I am starting my PhD (!!!) and this is the only reason why I don't use Zotero to read papers. I also hereby assign the copyright of all changes I have made to Digital Scholar.
You can see the diff onto upstream here: https://github.com/zotero/zotero-ios/compare/master...tylerhou:zotero-ios:stroke_eraser?expand=1
Thank you!
Tyler
I've finished the stroke eraser implementation I started a year ago in https://forums.zotero.org/discussion/110079/ios-object-stroke-eraser#latest. The UX is basically the same as the eraser in Notability and on the Remarkable. It supports undo, and I've also added a setting that allows the user to configure how the stroke tool should merge strokes (separate strokes means higher file sizes but better stroke erasing).
I did use Claude to help with much of the implementation (undo functionality; stroke merging settings) but I have also reviewed all of the code manually.
I am happy to make any changes to get this merged. I would like to get it merged soon; I am starting my PhD (!!!) and this is the only reason why I don't use Zotero to read papers. I also hereby assign the copyright of all changes I have made to Digital Scholar.
You can see the diff onto upstream here: https://github.com/zotero/zotero-ios/compare/master...tylerhou:zotero-ios:stroke_eraser?expand=1
Thank you!
Tyler