Issues with my Citation Style

s_vorgheim

Hi everyone, as the title says im having some trouble with a particular citation style im using. Im trying to learn how to edit citation styles, as the last one that has been published for my institution sadly is no longer up to standard.

Im trying to adapat this one: https://www.zotero.org/styles/hochschule-fur-wirtschaft-und-recht-berlin

I have made progress in adapting but i am now stuck on a problem i cant solve.
For some reason the citation style is adding unnessescary repetitions within my bibliography.

Example:

Frank, Sybille und Krawjesky, Georg (2018): Smarter Urbanismus und Urbanität, in: Bauriedl, Sybille und Strüver, Anke (Hrsg.): Smart City - Kritische Perspektiven auf die Digitalisierung in Städten: Digitale Technologien, Raumproduktion, Intervention, Bielefeld, Deutschland, 2018, abgerufen am 06.01.2023, https://www.degruyter.com/document/doi/10.1515/9783839443361/html, ISBN: 978-3-8394-4336-1, container-title: Smart City - Kritische Perspektiven auf die Digitalisierung in Städten.

Everything after the ISBN is unwanted. This only happens when citing book sections.

I think this is the responsible code section?

<bibliography et-al-min="100" et-al-use-first="1" hanging-indent="true">
<sort>
<key macro="hasUrl"/>
<key macro="author"/>
<key macro="date"/>
</sort>
<layout suffix=".">
<group font-weight="bold">
<text macro="author" font-style="normal" font-weight="bold"/>
<text macro="year-date" prefix=" (" suffix="):" font-weight="bold"/>
</group>
<text variable="title" prefix=" "/>
<choose>
<if type="webpage">
<text macro="date" prefix=", "/>
</if>
<else-if type="speech" match="any">
<text variable="publisher-place" prefix=", "/>
<text macro="date" prefix=", "/>
<text macro="accessed" prefix=", "/>
</else-if>
<else-if type="article-newspaper article-magazine article-journal" match="any">
<text value=" In: " font-style="italic"/>
<text variable="container-title" font-style="italic"/>
<text variable="collection-title" prefix=", Reihe "/>
<text variable="volume" prefix=", Band "/>
<text variable="issue" prefix=", Ausgabe "/>
<text macro="date" prefix=", "/>
<text macro="pages"/>
</else-if>
<else-if type="chapter paper-conference" match="any">
<text macro="editor" prefix=", in: " suffix=": "/>
<text variable="container-title" font-style="italic"/>
<text variable="publisher-place" prefix=", "/>
<text variable="edition" prefix=", "/>
<text macro="year-date" prefix=", "/>
<text macro="pages"/>
</else-if>
<else>
<text variable="publisher-place" prefix=", "/>
<text variable="edition" prefix=", "/>
<text macro="year-date" prefix=", "/>
</else>
</choose>
<choose>
<if variable="URL">
<text macro="accessed" prefix=", "/>
<text variable="URL" prefix=", "/>
</if>
</choose>
<text variable="ISBN" prefix=", ISBN: "/>
<text variable="note" prefix=", "/>
</layout>
</bibliography>

If there is a better way to share the citation style please let me know.

Any help welcome.

P.S. while im at it, i also noticed that the Bibliography needs to be sorted alphabeticaly by author name

damnation

Delete the "text variable note" at the end.
The note variable is the "Extra" field in Zotero and we generally don't use that in citation styles.

You can contribute your style to the repository by suggesting an edit to the current style. That then also serves as a basis for discussion and further and better help as you can then just share the link to your PR.

See 3b: https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md

s_vorgheim

Thank you very much, this has worked great.

I will contribute the style as soon as i am confident that it meets all the requirements set by my school and the CSL Guide.

damnation

Great.

The sorting issue is because in the sort section it has the "hasURL" macro in the first position. I don't know what the requirements are, but the style sorts by items with URLs first.
You want to double check if that is wanted or not. Some guides want a separate bibliography for internet resources and that would be the way to achieve that.

s_vorgheim

I just contributed the style to the repository, i hope i can save some of my co-students some time by doing so and i want to thank you for help.

damnation

What's the name of the style?
I don't see a new PR that looks like it could be yours: https://github.com/citation-style-language/styles/pulls

s_vorgheim

I thought ive followed the instructions fairly well but it appears i have made a mistake and accidently created a fork on my personal repository :) ?

Im not very proficient in using git, but ill try again.
Style name is supposed to be: HWR-Hochschule-fuer-Wirtschaft-und-Recht-Berlin-Fachbereich-2.csl

Edit: This might be a stupid question, but i cant seem to find the "Propose new file" Button mentionted in step 4.

damnation

All I always do is go here https://github.com/citation-style-language/styles

Then click on "Add File" > "Create new file"

Add the style name, code and click on "Commit Changes" and add a link to this thread on the little window that opens.
You'll need to commit twice, I think.

s_vorgheim

I have commited the style, next window that opens offers me to Create a pull request, do i need to do that?

damnation

Yes.