There's no firm maximum. At some library size, and depending on your hardware, Zotero will start slowing down (that number is somewhere between 20k and 250k items, I'd say)