bookmark import should use "description" as "abstract"

anarcat · March 31, 2014

When importing a bookmarks file, the "description" field is lost. It could be imported as well, as the "abstract" field.

anarcat · March 31, 2014

and here's a patch:


--- Bookmarks.js.orig   2014-03-31 00:54:46.802439614 -0400
+++ Bookmarks.js        2014-03-31 00:55:49.859138263 -0400
@@ -93,6 +93,7 @@
                                        case "HREF":    item.url = hits[2];
                                                                        break;
                                        case "TAGS": item.tags = hits[2].split(','); break;
+                                       case "DESCRIPTION": item.abstractNote = hits[2]; break;
                                        case "ICON": break;
                                        case "ICON_URI": break;
                                        case "ADD_DATE":

ajlyon · March 31, 2014

Can you just make a pull request here: https://github.com/zotero/translators/blob/master/Bookmarks.js

Log in and hit the "Edit" button-- it'll fork the repo and submit your change as a pull request.

anarcat · March 31, 2014

thanks, i am hesitant in submitting issues directly on github since my last input... https://github.com/zotero/zotero/issues/424

here's the pull request: https://github.com/zotero/translators/pull/706

dstillman · March 31, 2014

thanks, i am hesitant in submitting issues directly on github since my last input...

(It's feature requests and bug reports that should be posted here first. If you have an actual patch, you can always submit a pull request directly on GitHub — we just might not accept it. Before beginning a lot of work it's usually a good idea to discuss it here or, for more technical discussions, on zotero-dev first, since you'll have a better idea of whether the existing behavior is intended (as was the case on your other issue), and the discussion may shape the patch.)