Added style for New Zealand Veterinary Journal (NZVJ)

sumostorm
Added a style for NZVJ. Books, book chapters, journal article and document all working properly.

git://gist.github.com/3464277.git
  • adamsmith
    please check line 132 - that looks like it's not finished?

    In line 99 - I assume you mean <text variable="publisher"/>?
  • sumostorm
    Thanks adam. I'll have a look, correct and then reply back. Cheers!
  • sumostorm
    Hey Adam,

    I cleaned those up, but I noticed a new problem as I was testing. For some reason disambiguation isn't working properly (or at least as I would expect.) I've updated the gist with my latest csl version and exported as rdf the sample citations I'm testing with.

    The suffix appended to the year for disambiguation shows up correctly in the in-text citation, but is not showing up as I would expect in the bibliography. Specifically, if a URL is present in the citation, the disambiguation suffix is showing up on the accessed date instead of published date.

    https://gist.github.com/3464277

    Any ideas?

    Thanks
  • adamsmith
    edited August 26, 2012
    that looks like a bug - the disambiguation suffix gets attached to whatever date comes first - typically that's not a problem, since author-date styles have the issued date right after the authors, but here it is. fbennett will have to take a look.

    edit: otherwise the style looks good, I'll put it up asap.
  • adamsmith
    style is up - for future reference: you're relying on suffix a lot for commas and spaces between parts of the citation - as soon as you get missing fields that tends to cause problems (like double commas or so), so it's recommended to rely as much as possible on groups and delimiters.
  • sumostorm
    edited August 26, 2012
    That makes sense. I'll see if I can clean it up some when I have some time.

    Any work-around for the disambiguation issue that can be added to the style? Or just need to wait for the next update to the Zotero code? Probably won't be an issue with my real citations - just curious mostly.

    Also, if I update the style, what is the process for getting the revision uploaded? Just repost back to this forum, or is it different for updates?

    Cheers!
  • adamsmith
    edited August 26, 2012
    I don't think there is a workaround - Frank (fbennett) has already e-mailed me about a fix, so that will make it into Zotero relatively quickly.

    Future updates - posting here will do, but especially for existing styles, issuing a pull request (option A) is very easy and reduces my work in getting this into the repo to clicking a button:
    https://github.com/citation-style-language/styles/wiki/Submitting-Styles

    If you do that, please work with the copy that's now uploaded, I made some minor cosmetic changes (indenting and removing redundancies, nothing substantial).

    edit: as for coding: the things _really_ to avoid - they may very well be disallowed in future csl versions - are trailing spaces in suffixes and leading spaces in prefixes. When I code I try to avoid spaces in affixes altogether. Zotero will auto-remove directly adjacent punctuation, but not if it's sparated by a space.
  • fbennett
    About the year-suffix issue, why not just set it explictly, in citation and bibliography, with <text variable="year-suffix"/>?
  • sumostorm
    edited August 30, 2012
    I tried adding <text variable="year-suffix"/>, but it either eliminates the disambiguation all together, or adds a space after the year for the citation and then no suffix at all in the bibliography (depending on where the line is placed in the xml file.)

    I am not an xml expert at all though, so may not have put the line where you wanted me to. I tried various places and the above was the outcome, depending on where I put it.
  • fbennett
    Here's an example using that style (see lines 64-81). I've tested this, and it works as expected.

    https://gist.github.com/3546390
  • adamsmith
    fixed on the repo.
Sign In or Register to comment.