[citeproc-bug] Format error with disambiguated in-line cites

tersiphone

Hi,

I set-up my in-line citations to disambiguate by year, such that they are displayed as follows:

(Khan et al. 1980; Lance et al. 1985; Thorbjarnarson 1993a,b; Hekkala et al. 2011)

Unfortunately, the cite immediately before the disambiguated citation seems to not want to follow the command and this is what I get:

(Khan et al. 1980; Lance et al. 1985,Thorbjarnarson 1993a,b; Hekkala et al. 2011)

Here is the relevant code:

<macro name="year-date">
<choose>
<if variable="issued">
<date variable="issued">
<date-part name="year"/>
</date>
<text variable="year-suffix" font-style="normal"/>
</if>
<else>
<text term="no date" form="short"/>
</else>
</choose>
</macro>

<citation et-al-min="3" et-al-use-first="1" disambiguate-add-year-suffix="true" collapse="year-suffix" year-suffix-delimiter="," disambiguate-add-givenname="true" givenname-disambiguation-rule="by-cite">
<sort>
<key macro="year-date"/>
<key macro="author-short"/>
</sort>
<layout delimiter="; " prefix="(" suffix=")">
<group delimiter=":">
<group delimiter=" ">
<text macro="author-short"/>
<text macro="year-date"/>
</group>
<text variable="locator"/>
</group>
</layout>
</citation>


Thoughts??

adamsmith

looks like you mistyped something. Your "this is what I get" is the same as the "this is what I want" (which would be great, but I gather isn't actually the case).

tersiphone

Nope - they are different. Here it is again:

What I want: (Khan et al. 1980; Lance et al. 1985; Thorbjarnarson 1993a,b; Hekkala et al. 2011)

What I get: (Khan et al. 1980; Lance et al. 1985,Thorbjarnarson 1993a,b; Hekkala et al. 2011)

The difference is in the Lance et al. 1985 citation, which in the former is followed by a "; " and in the latter is followed by a ","

adamsmith

Ah yes. That looks like a bug. Could you add [citeproc-bug] to the title of this thread by modifying your first post?

@Frank: validating copy of the style is here:
https://gist.github.com/adam3smith/426e0ea28e4fa773d20b
Problem is that the style always turns the delimiter before a cite collapsed by year suffix into a comma. See the above example, but I was able to replicate that with random data. Let me know if you need anything else.

(@tersiphone -- you always want to validate when something isn't working to make sure the problem isn't your code)

tersiphone

Thanks Adam. Here is a slightly updated version of the style (which still has this problem):

https://gist.github.com/anonymous/4128451671229336d71f

fbennett

Confirmed. I'll take a look.

fbennett

Found the problem in the code. There are some other changes to the processor queued up, so it may be a few days before the fix is released.

tersiphone

Thanks @Frank. Once the fix is released is there anything that I need to do to see the change as part of either a desktop (Zotero or Mendeley) or web client (e.g., update the client)? Or is it automatic?

fbennett

Processor updates are more frequent than Zotero releases, so when a processor release is ready, I put up a "patch plugin" that users affected by a bug can install immediately (to be removed after the new processor appears in a Zotero release). I'll post a link back to this thread when the update goes up.

tersiphone

Thanks. Any idea how this may be incorporated into Mendeley?

adamsmith

For Mendeley we don't know, you'd have to ask them. For the visual editor hosted at editor.citationstyles.org, that kind of happens when I get to it. For the one at Mendeley, again, I don't know.

fbennett

I can send a note to the Mendeley team when the update is ready.

tersiphone

Thanks!