Highwire 2.0

adamsmith

I'm having some troubles with Highwire 2.0 since the last update.
It's not broken across the board, but I get an error for multiple items here (proxy removed from URLS)

http://ser.oxfordjournals.org/content/current

[JavaScript Error: "translator called select items with no items" {file: "file:///home/sebastian/.mozilla/firefox/wkxw8okh.default/zotero/translators/Highwire%202.0.js" line: 0}]
Report ID: 1152446284

and for an individual item here
http://pas.sagepub.com/content/10/2/155.full.pdf+html
[JavaScript Error: "TypeError: match is null" {file: "file:///home/sebastian/.mozilla/firefox/wkxw8okh.default/zotero/translators/Highwire%202.0.js" line: 0}]
Report ID: 246452648

I haven't tested this extensively, but since Highwire was recently updated I wanted to flag it.

ajlyon

I'll look into this.

ajlyon

You know the drill: https://github.com/ajlyon/zotero-bits/raw/master/Highwire 2.0.js

I can't replicate the latter, but the first is indeed an issue with ToC parsing on Oxford, and it was probably broken before the recent update. My fix could use some testing on other Highwire 2.0 sites (see the code for examples), specifically with journal tables of contents.

adamsmith

thanks - I checked a couple and in general this works, including the first link above and sage -

the second link above fails because of some proxy related issue:
The actual address I used is
http://pas.sagepub.com.turing.library.northwestern.edu/content/10/2/155.full.pdf+html
if I use an alternate account and go in without proxy, Zotero import works fine -
also, other sagepub journals work with that proxy, but other issues from the same journal don't -
I'd say we put this under weird fluke and don't worry about it.

adamsmith

Which reminds me - is a temporary disable proxy-redirection feature included in the current beta?

ajlyon

Highwire fix now in the SVN: https://www.zotero.org/trac/changeset/7334

schmid

Sorry, I got an error with it at Science Magazine:
http://www.sciencemag.org/content/330/6009/1364.abstract
The Error Console says:
Error: TypeError: match is null Source File: ..../zotero/translators/Highwire%202.0.js

dstillman

I've pushed ajlyon's updated Highwire translator. Your copy of Zotero should auto-update within 24 hours, or you can update manually by clicking Update Now in the General pane of the Zotero prefs.

schmid

Sorry again, still the same error message with the new translator at this page
http://www.sciencemag.org/content/330/6009/1364.abstract

ajlyon

That's because the translator is rather inflexible and even case variations break it.
The version now at https://github.com/ajlyon/zotero-bits/raw/master/Highwire 2.0.js works.

I'll get this into SVN when I'm back at an SVN-equipped computer, unless Dan wants to commit the three-character patch before then.

When I feel motivated or sick of fixing Highwire, I'll go and rework the translator to be more sane in how it parses these pages.

ajlyon

This has now been committed to the repository (https://www.zotero.org/trac/changeset/7512) and will be in the next version of Zotero, or when Dan pushes it to clients. In the meantime, people with this problem can install the updated version from Github as described above.